Skip to content

WIP: test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers#1409

Closed
machine424 wants to merge 1 commit intoopenshift:mainfrom
machine424:deln
Closed

WIP: test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers#1409
machine424 wants to merge 1 commit intoopenshift:mainfrom
machine424:deln

Conversation

@machine424
Copy link

@machine424 machine424 commented Sep 4, 2025

No description provided.

machine424
machine424 commented Sep 4, 2025
View reviewed changes
test/e2e/vsphere/machines.go
// Remove machine
By("delete the machine")
err = mc.Machines(util.MachineAPINamespace).Delete(ctx, machine.Name, metav1.DeleteOptions{})
policy := metav1.DeletePropagationForeground
Copy link
Author

@machine424 machine424 Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this is implemented by the controller, let's see

machine424
machine424 commented Sep 4, 2025
View reviewed changes
test/e2e/vsphere/machines.go
err = mc.MachineSets(util.MachineAPINamespace).Delete(ctx, ddMachineSet.Name, metav1.DeleteOptions{PropagationPolicy: &policy})
Expect(err).NotTo(HaveOccurred())

// Verify / wait for machineset is removed
Copy link
Author

@machine424 machine424 Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the policy is propagated to machines and is implemented, let's see

@openshift-ci openshift-ci bot requested review from damdo and racheljpg September 4, 2025 13:08
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machine424
Copy link
Author

machine424 commented Sep 4, 2025

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6a5b45d0-899e-11f0-876f-3fa2e09ebf24-0

@damdo
Copy link
Member

damdo commented Sep 5, 2025

Hey @machine424 can you explain a little why this change is required and how that fixes your issue, thanks!

@machine424 machine424 changed the title test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers WIP: test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers Sep 5, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@machine424
Copy link
Author

machine424 commented Sep 5, 2025

Hello @damdo
This is just an experiment, I was planning to reach out to you about it once I know more.
We’ve noticed that this test seems to leave some nodes behind, and a few subsequent tests don’t handle that well. I was trying out foreground deletion, if it’s implemented, it should help the test clean up the underlying resources after itself.

See https://issues.redhat.com/browse/OCPBUGS-61193?focusedId=27993433&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-27993433
let's continue the discussion there if you want.

@damdo
Copy link
Member

damdo commented Sep 10, 2025

Ok thanks do keep me posted on this

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 5, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2025
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 5, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 4, 2026

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 4, 2026
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 4, 2026

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Feb 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

@racheljpg racheljpg Awaiting requested review from racheljpg

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@machine424 @damdo @openshift-bot @openshift-merge-robot